Disallow assigning others as reviewer/committer on open patches #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelteF
force-pushed
the
main
branch
2 times, most recently
from
32d0e40 to
0f23363
Compare
JelteF
force-pushed
the
only-assign-self-as-reviewer-committer
branch
from
abbcfae to
975093a
Compare
JelteF
added a commit
that referenced
this pull request
Mar 4, 2025
Many people assign themselves to open entries as a reviewer/committer as a sort of bookmarking system for open patches they are interested in. Currently it's allowed for others to assign anyone as a reviewer/committer, thus effectively modifying people their bookmarking system. This is especially made worse because you can sign up in your profile to receive email updates from the commitfest app for patches that you are reviewer/committer of and would then thus start receiving updates for patches you might not be interested in. Assigning reviewers/committers to closed patches is still be allowed. When committing, reviewers are sometimes added by the committer to reflect the same as their Reviewed-By footer, even if those reviewers didn't explicitly sign up as a reviewer on the commitfest app for this patch. Fixes #12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many people assign themselves to open entries as a reviewer/committer as a sort of bookmarking system for open patches they are interested in. Currently it's allowed for others to assign anyone as a reviewer/committer, thus effectively modifying people their bookmarking system. This is especially made worse because you can sign up in your profile to receive email updates from the commitfest app for patches that you are reviewer/committer of and would then thus start receiving updates for patches you might not be interested in.
Assigning reviewers/committers to closed patches is still be allowed. When committing, reviewers are sometimes added by the committer to reflect the same as their Reviewed-By footer, even if those reviewers didn't explicitly sign up as a reviewer on the commitfest app for this patch.
Fixes #12